This repository was archived by the owner on May 27, 2025. It is now read-only.
feat(PROTO-945): implement Redis-based rate limiting #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jowparks
commented
Mar 18, 2025
jowparks
commented
- Added RedisRateLimit for distributed rate limiting, allowing connection tracking across multiple instances.
- Updated Cargo.toml to include new dependencies for Redis and related packages.
- Enhanced README with Redis integration instructions and usage examples.
- Modified main.rs to support Redis configuration via command-line arguments.
- Updated Cargo.lock with new package versions and dependencies.
jowparks
commented
Mar 18, 2025
jowparks
force-pushed
the
feat-proto-945-redis-ratelimiter
branch
4 times, most recently
from
fd8c9ea to
6f22d10
Compare
|
The security audit failure seems unrelated to my changes, also it seems like we could safely bypass the error as we don't have overflow checking enabled: |
|
@jowparks re: the security audit -- we can skip for now. @angel-ding-cb is fixing in #5 |
…dencies - Added RedisRateLimit for distributed rate limiting, allowing connection tracking across multiple instances. - Updated Cargo.toml to include new dependencies for Redis and related packages. - Enhanced README with Redis integration instructions and usage examples. - Modified main.rs to support Redis configuration via command-line arguments. - Updated Cargo.lock with new package versions and dependencies.
jowparks
force-pushed
the
feat-proto-945-redis-ratelimiter
branch
from
6f22d10 to
e57c540
Compare
danyalprout
approved these changes
Mar 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.